seedhammer/dcrd
seedhammer/dcrd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

blockchain: Remove impossible condition checks. (#557)

Browse Source 
This removes a couple of checks that are completely impossible to hit.

These are impossible to hit because there is a maximum protocol limit of
1MiB and the absolute minimum possible transaction size that will
successfully deserialize with no inputs and no outputs is 15 bytes
(which is itself an invalid transaction anyways), which means a maximum
of 66,666 of these invalid transactions could fit into a 1MiB block.
Since the check is comparing against 393,216 on mainnet and 1,000,000 on
testnet and simnet, it can easily be seen it simply isn't possible to
hit.

Technically, if it were possible to hit these conditions, changing them
would be a hard fork, however, since they're impossible to hit, this is
effectively a noop change in regards to consensus.
This commit is contained in:
Dave Collins 2017-02-09 09:54:29 -06:00 committed by John C. Vernaleo
parent 278a491543
commit 876ac3fa15
1 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
blockchain/validate.go
View File

@ -409,21 +409,6 @@ func checkBlockSanity(block *dcrutil.Block, timeSource MedianTimeSource,
"any transactions")
}
// A block must not have more transactions than the max block payload.
if numTx > chainParams.MaximumBlockSize {
str := fmt.Sprintf("block contains too many transactions - "+
"got %d, max %d", numTx, chainParams.MaximumBlockSize)
return ruleError(ErrTooManyTransactions, str)
}
// A block must not have more stake transactions than the max block payload.
numStakeTx := len(msgBlock.STransactions)
if numStakeTx > chainParams.MaximumBlockSize {
str := fmt.Sprintf("block contains too many stake transactions - "+
"got %d, max %d", numStakeTx, chainParams.MaximumBlockSize)
return ruleError(ErrTooManyTransactions, str)
}
// A block must not exceed the maximum allowed block payload when
// serialized.
serializedSize := msgBlock.SerializeSize()