seedhammer/dcrd
seedhammer/dcrd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rpcserver: Avoid error in handleRebroadcastWinners.

Browse Source 
This downgrades an error when rebroadcasting the winning tickets to a
logged warning.

This is necessary because it is a legitimate state to have a chain tip
header returned by the Chain.TipGeneration() while the actual block data
is not yet available for the LotteryDataForBlock to complete.

Prior to this change, a voting wallet connecting to a dcrd instance with
multiple chain tip headers without the associated data would be unable
to re-start voting for blocks due to the associated RPC call failing.
This commit is contained in:
Matheus Degiovani 2022-07-22 13:19:11 -03:00 committed by GitHub
parent 75f1b4dac2
commit 32ee3fb74d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
internal/rpcserver/rpcwebsocket.go
View File

@ -2071,8 +2071,11 @@ func handleRebroadcastWinners(wsc *wsClient, icmd interface{}) (interface{}, err
for i := range blocks {
winningTickets, _, _, err := cfg.Chain.LotteryDataForBlock(&blocks[i])
if err != nil {
return nil, rpcInternalError("Lottery data for block "+
"failed: "+err.Error(), "")
// This can legitimately happen if we have the block
// header but not the block data, so just log a warning
// and keep sending notifications.
log.Warnf("Lottery data for block failed: %v", err)
continue
}
ntfnData := &WinningTicketsNtfnData{
BlockHash: blocks[i],