openclaw/openclaw-windows-node
openclaw/openclaw-windows-node
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 4 Wiki Activity

improve: use FrozenSet for ExecEnvSanitizer blocked-names lookup

Browse Source 
_blockedNames is initialised once at startup and never mutated.
FrozenSet gives lower constant-factor O(1) Contains() compared to
HashSet, and matches the pattern already used throughout the codebase
(ChannelHealth.s_healthyStatuses / s_intermediateStatuses in Models.cs,
NotificationCategorizer.ChannelMap / IntentMap, etc.).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
github-actions[bot] 2026-04-21 13:02:46 +00:00 committed by GitHub
parent 9134be49e1
commit 700d58e459
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 34 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
src/OpenClaw.Shared/ExecEnvSanitizer.cs
View File

@ -1,4 +1,5 @@
using System;
using System.Collections.Frozen;
using System.Collections.Generic;
namespace OpenClaw.Shared;
@ -11,38 +12,39 @@ internal sealed class ExecEnvSanitizeResult
internal static class ExecEnvSanitizer
{
private static readonly HashSet<string> _blockedNames = new(StringComparer.OrdinalIgnoreCase)
{
"PATH",
"PATHEXT",
"ComSpec",
"PSModulePath",
"NODE_OPTIONS",
"NODE_PATH",
"PYTHONPATH",
"PYTHONSTARTUP",
"PYTHONUSERBASE",
"RUBYOPT",
"RUBYLIB",
"PERL5OPT",
"PERL5LIB",
"PERLIO",
"GIT_SSH",
"GIT_SSH_COMMAND",
"GIT_EXEC_PATH",
"GIT_PROXY_COMMAND",
"GIT_ASKPASS",
"BASH_ENV",
"ENV",
"CDPATH",
"PROMPT_COMMAND",
"ZDOTDIR",
"LD_PRELOAD",
"LD_LIBRARY_PATH",
"LD_AUDIT",
"DYLD_INSERT_LIBRARIES",
"DYLD_LIBRARY_PATH"
};
private static readonly FrozenSet<string> _blockedNames =
new HashSet<string>(StringComparer.OrdinalIgnoreCase)
{
"PATH",
"PATHEXT",
"ComSpec",
"PSModulePath",
"NODE_OPTIONS",
"NODE_PATH",
"PYTHONPATH",
"PYTHONSTARTUP",
"PYTHONUSERBASE",
"RUBYOPT",
"RUBYLIB",
"PERL5OPT",
"PERL5LIB",
"PERLIO",
"GIT_SSH",
"GIT_SSH_COMMAND",
"GIT_EXEC_PATH",
"GIT_PROXY_COMMAND",
"GIT_ASKPASS",
"BASH_ENV",
"ENV",
"CDPATH",
"PROMPT_COMMAND",
"ZDOTDIR",
"LD_PRELOAD",
"LD_LIBRARY_PATH",
"LD_AUDIT",
"DYLD_INSERT_LIBRARIES",
"DYLD_LIBRARY_PATH"
}.ToFrozenSet(StringComparer.OrdinalIgnoreCase);
internal static ExecEnvSanitizeResult Sanitize(Dictionary<string, string>? env)
{