openclaw/crawlkit
openclaw/crawlkit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 2 Wiki Activity

fix(tui): match gitcrawl action menu behavior

Browse Source
This commit is contained in:
Vincent Koc 2026-05-04 00:01:20 -07:00
parent af0999792e
commit d41cfdeacb
No known key found for this signature in database
2 changed files with 19 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tui/tui.go
View File

@ -711,6 +711,7 @@ func (m *model) applyInitialGroupMode() {
type paneFocus int
const (
focusNone paneFocus = -1
focusRows paneFocus = iota
focusContext
focusDetail
@ -1115,9 +1116,9 @@ func (m *model) updateMenuKey(key tea.KeyMsg) tea.Cmd {
switch key.String() {
case "ctrl+c":
return tea.Quit
case "q", "ctrl+d":
case "ctrl+d":
return tea.Quit
case "esc":
case "q", "esc":
m.closeMenu()
case "up", "k":
m.menuIndex = m.nextSelectableMenuIndex(-1)
@ -1164,7 +1165,7 @@ func (m *model) updateMenuKey(key tea.KeyMsg) tea.Cmd {
}
func (m *model) openActionMenu() {
m.openActionMenuFor(m.focus)
m.openActionMenuFor(focusNone)
}
func (m *model) openActionMenuFor(context paneFocus) {

26
tui/tui_test.go
View File

@ -423,16 +423,17 @@ func TestVeryNarrowPanesStillShowCompactColumns(t *testing.T) {
}
}
func TestQQuitsFromMenuAndFilterModes(t *testing.T) {
func TestQClosesMenuAndQuitsFromFilterModes(t *testing.T) {
m := newModel(Options{Title: "archive", Items: []Item{{Title: "alpha"}}})
updated, _ := m.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune{'a'}})
m = updated.(model)
if !m.menuOpen {
t.Fatal("menu did not open")
}
_, cmd := m.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune{'q'}})
if cmd == nil {
t.Fatal("q in menu should quit")
updated, cmd := m.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune{'q'}})
m = updated.(model)
if cmd != nil || m.menuOpen {
t.Fatalf("q in menu should close only, menu=%v cmd=%v", m.menuOpen, cmd)
}
m = newModel(Options{Title: "archive", Items: []Item{{Title: "alpha"}}})
@ -1050,9 +1051,12 @@ func TestKeyboardActionShortcutAliasOpensMenu(t *testing.T) {
updated, _ := m.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune{'a'}})
m = updated.(model)
if !m.menuOpen || m.menuTitle != "Row Actions" {
if !m.menuOpen || m.menuTitle != "Actions" {
t.Fatalf("action shortcut menu open=%v title=%q", m.menuOpen, m.menuTitle)
}
if m.menuFloating {
t.Fatal("keyboard action menu should render in the detail pane")
}
}
func TestActionMenuUsesGitcrawlDetailChrome(t *testing.T) {
@ -1066,17 +1070,17 @@ func TestActionMenuUsesGitcrawlDetailChrome(t *testing.T) {
m.height = 30
updated, _ := m.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune{'a'}})
m = updated.(model)
if m.status != "Channels Actions" {
t.Fatalf("action menu status = %q, want Channels Actions", m.status)
if m.status != "Actions" {
t.Fatalf("action menu status = %q, want Actions", m.status)
}
view := stripANSI(m.View())
for _, want := range []string{"Thread full", "Channels Actions", "group scope", "Open selected URL"} {
for _, want := range []string{"Thread full", "Actions", "current selection", "Open selected URL"} {
if !strings.Contains(view, want) {
t.Fatalf("action menu chrome missing %q:\n%s", want, view)
}
}
if strings.Contains(view, "Row Actions") {
t.Fatalf("action menu should use semantic pane titles in visible chrome:\n%s", view)
if strings.Contains(view, "Row Actions") || strings.Contains(view, "Channels Actions") {
t.Fatalf("keyboard action menu should use gitcrawl-style generic title:\n%s", view)
}
if strings.Contains(view, "Detail Row Actions") {
t.Fatalf("action menu should keep gitcrawl-style detail chrome:\n%s", view)
@ -1094,7 +1098,7 @@ func TestActionMenuTitlesFollowFocusedPane(t *testing.T) {
m.width = 160
m.height = 30
m.focus = focusContext
m.openActionMenu()
m.openActionMenuFor(focusContext)
if m.status != "Messages Actions" {
t.Fatalf("context action menu status = %q, want Messages Actions", m.status)
}