fix(tui): show pane action titles in status

This commit is contained in:
Vincent Koc 2026-05-03 23:45:44 -07:00
parent d26af59f14
commit 4080014321
No known key found for this signature in database
2 changed files with 10 additions and 4 deletions

View File

@ -1342,7 +1342,7 @@ func (m *model) openMenu(title string, items []menuItem) {
m.showHelp = false
m.menuOpen = true
m.menuTitle = title
m.status = firstNonEmpty(title, "Actions")
m.status = m.displayMenuTitle()
m.menuItems = append([]menuItem(nil), items...)
m.menuIndex = m.firstSelectableMenuIndex()
m.menuOff = 0

View File

@ -1066,15 +1066,18 @@ func TestActionMenuUsesGitcrawlDetailChrome(t *testing.T) {
m.height = 30
updated, _ := m.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune{'a'}})
m = updated.(model)
if m.status != "Row Actions" {
t.Fatalf("action menu status = %q, want Row Actions", m.status)
if m.status != "Channels Actions" {
t.Fatalf("action menu status = %q, want Channels Actions", m.status)
}
view := stripANSI(m.View())
for _, want := range []string{"Thread full", "Channels Actions", "Row Actions", "group scope", "Open selected URL"} {
for _, want := range []string{"Thread full", "Channels Actions", "group scope", "Open selected URL"} {
if !strings.Contains(view, want) {
t.Fatalf("action menu chrome missing %q:\n%s", want, view)
}
}
if strings.Contains(view, "Row Actions") {
t.Fatalf("action menu should use semantic pane titles in visible chrome:\n%s", view)
}
if strings.Contains(view, "Detail Row Actions") {
t.Fatalf("action menu should keep gitcrawl-style detail chrome:\n%s", view)
}
@ -1092,6 +1095,9 @@ func TestActionMenuTitlesFollowFocusedPane(t *testing.T) {
m.height = 30
m.focus = focusContext
m.openActionMenu()
if m.status != "Messages Actions" {
t.Fatalf("context action menu status = %q, want Messages Actions", m.status)
}
view := stripANSI(m.View())
for _, want := range []string{"Messages Actions", "selected item scope"} {
if !strings.Contains(view, want) {