From 2b5bab366508636875fbdbc52a62a2bc37caa5fd Mon Sep 17 00:00:00 2001 From: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Date: Fri, 8 May 2026 23:31:20 +0000 Subject: [PATCH] chore: apply event sweep result for openclaw-openclaw#79558 [skip ci] --- records/openclaw-openclaw/items/79558.md | 254 +++++++++++++++++++++++ 1 file changed, 254 insertions(+) create mode 100644 records/openclaw-openclaw/items/79558.md diff --git a/records/openclaw-openclaw/items/79558.md b/records/openclaw-openclaw/items/79558.md new file mode 100644 index 0000000000..72f73c1f7c --- /dev/null +++ b/records/openclaw-openclaw/items/79558.md @@ -0,0 +1,254 @@ +--- +review_comment_synced_at: 2026-05-08T23:31:18.771Z +number: 79558 +repository: openclaw/openclaw +type: issue +title: "Clarify Node defaults between install.sh and local-prefix install-cli.sh" +url: https://github.com/openclaw/openclaw/issues/79558 +state_at_review: open +item_created_at: 2026-05-08T23:23:46Z +item_updated_at: 2026-05-08T23:23:46Z +author: McoreD +author_association: NONE +labels: [] +reviewed_at: 2026-05-08T23:30:39.415Z +main_sha: b6423fbd323cc1ecfc8ef452b7d862a5ec0685f8 +pull_head_sha: unknown +latest_release: v2026.5.7 +latest_release_sha: eeef4864494f859838fec1586bedbab1f8fa5702 +fixed_release: unknown +fixed_sha: unknown +fixed_at: unknown +fixed_pr_url: unknown +fixed_pr_number: unknown +fixed_pr_title: unknown +fixed_pr_merged_at: unknown +fixed_pr_sha: unknown +fixed_pr_confidence: unknown +fixed_pr_source: unknown +review_policy: 421d766edf9f773b +review_model: gpt-5.5 +review_reasoning_effort: high +review_sandbox: danger-full-access +review_service_tier: default +review_prompt_chars: 38510 +review_static_prompt_chars: 33412 +review_context_chars: 3859 +review_schema_chars: 14081 +review_additional_prompt_chars: 0 +review_context_elapsed_ms: 1423 +review_codex_elapsed_ms: 209078 +review_mode: propose +review_status: complete +local_checkout_access: verified +item_snapshot_hash: e0116e046ef3d3ae0dab39e2bd443ea2e5392f20f9402ca6341807128982b75c +close_comment_sha256: none +review_comment_sha256: fa52eb6811c3f90b4c29ed80ee3b9915272333f8ef60e8a597e5b04bb32f88d5 +review_comment_id: 4410567128 +review_comment_url: https://github.com/openclaw/openclaw/issues/79558#issuecomment-4410567128 +decision: keep_open +close_reason: none +confidence: high +action_taken: kept_open +work_candidate: queue_fix_pr +work_confidence: high +work_priority: medium +work_status: candidate +work_reason_sha256: af4a9c1827d8198ee81f239c56a3ea6275ede09e73b73cd50297f93e4495511e +work_prompt_sha256: 8d49eabea17171a4c4060cdaf6dca86ee07b3ecf176c361e85d8fb75110c1523 +work_cluster_refs: ["https://github.com/openclaw/openclaw/issues/79558","https://github.com/openclaw/openclaw/issues/75250","https://github.com/openclaw/openclaw/pull/76092"] +work_validation: ["pnpm docs:list","pnpm docs:check-mdx","pnpm docs:check-links","git diff --check"] +work_likely_files: ["docs/install/index.md","docs/install/installer.md","docs/install/node.md"] +item_category: docs +reproduction_status: source_reproducible +reproduction_confidence: high +requires_new_feature: false +requires_new_config_option: false +requires_product_decision: false +real_behavior_proof_status: not_applicable +real_behavior_proof_evidence_kind: not_applicable +real_behavior_proof_needs_contributor_action: false +--- + +# [#79558: Clarify Node defaults between install.sh and local-prefix install-cli.sh](https://github.com/openclaw/openclaw/issues/79558) + +Type: issue + +URL: [https://github.com/openclaw/openclaw/issues/79558](https://github.com/openclaw/openclaw/issues/79558) + +Author: McoreD + +Author association: NONE + +Labels: none + +Created at: May 8, 2026, 23:23 UTC + +Updated at: May 8, 2026, 23:23 UTC + +Reviewed against: [b6423fbd323c](https://github.com/openclaw/openclaw/commit/b6423fbd323cc1ecfc8ef452b7d862a5ec0685f8) + +Codex review: model gpt-5.5, reasoning high + +Latest release at review time: [v2026.5.7](https://github.com/openclaw/openclaw/releases/tag/v2026.5.7) ([eeef4864494f](https://github.com/openclaw/openclaw/commit/eeef4864494f859838fec1586bedbab1f8fa5702)) + +Fixed in: not determined + +## Decision + +Keep open: kept open + +Confidence: high + +Action taken: kept_open + +## Summary + +Keep open: current main still leaves a real docs/install messaging gap between the general Node 24 recommendation and the local-prefix installer’s Node 22.22.0 managed runtime behavior. + +## What This Changes + +Clarify the mismatch between the main installer’s Node 24 default and the local-prefix CLI installer’s Node 22.22.0 managed runtime default. + +## Best Possible Solution + +Document the local-prefix managed Node default prominently, explain how it can differ from the shell/global Node, and warn users to rebuild OpenClaw-adjacent native tools with the runtime that will load them. + +## Reproduction Assessment + +Yes for the docs/install mismatch: source inspection shows the main installer defaulting to Node 24, the docs recommending Node 24, and the local-prefix installer/docs defaulting to Node 22.22.0. I did not run a destructive local-prefix install, but the behavior is clear from the served installer script and current docs. + +## Solution Assessment + +Yes, the best narrow solution is to clarify docs and install messaging without changing the managed Node default. A default change to Node 24 should remain a separate maintainer decision with release validation. + +## Review Findings + +Overall correctness: not a patch + +Overall confidence: 0.86 + +Full review comments: + +- none + +## Security Review + +Status: not_applicable + +Summary: This is a non-security issue with no patch under review, so there is no security diff to assess. + +Concerns: + +- none + +## Real Behavior Proof + +Status: not_applicable + +Evidence kind: not_applicable + +Needs contributor action: false + +Summary: This is an issue, not an external PR, so contributor real-behavior proof gating does not apply. + +## Work Candidate + +Candidate: queue_fix_pr + +Confidence: high + +Priority: medium + +Status: candidate + +Reason: This is a narrow docs/install messaging cleanup with clear affected files and validation; it should not change Node defaults unless a maintainer explicitly asks for that behavior change. + +Cluster refs: + +- https://github.com/openclaw/openclaw/issues/79558 +- https://github.com/openclaw/openclaw/issues/75250 +- https://github.com/openclaw/openclaw/pull/76092 + +Likely files: + +- docs/install/index.md +- docs/install/installer.md +- docs/install/node.md + +Validation: + +- pnpm docs:list +- pnpm docs:check-mdx +- pnpm docs:check-links +- git diff --check + +## Repair Work Prompt + +Fix the docs clarity gap for https://github.com/openclaw/openclaw/issues/79558. Update the install docs to distinguish the normal/global Node 24 recommendation from the local-prefix installer’s managed Node 22.22.0 default, explain that the managed prefix Node can intentionally differ from the user’s shell Node, and warn that OpenClaw-adjacent native tools should be installed or rebuilt with the runtime that will load them. Keep the change docs-focused in `docs/install/index.md`, `docs/install/installer.md`, and `docs/install/node.md` as needed; do not change installer defaults or add new config. If you add actual installer output in a separate source surface, add the corresponding user-facing changelog entry; for docs-only clarification, no changelog is expected. Validate docs formatting and links. + +## Evidence + +- **Main installer default:** `scripts/install.sh` sets `NODE_DEFAULT_MAJOR=24`. + - file: [scripts/install.sh:19](https://github.com/openclaw/openclaw/blob/b6423fbd323cc1ecfc8ef452b7d862a5ec0685f8/scripts/install.sh#L19) + - command: `nl -ba scripts/install.sh | sed -n '1,60p'` + - sha: [b6423fbd323c](https://github.com/openclaw/openclaw/commit/b6423fbd323cc1ecfc8ef452b7d862a5ec0685f8) +- **Node docs recommendation:** `docs/install/node.md` says Node 24 is the default and recommended runtime, while Node 22.16+ remains supported. + - file: [docs/install/node.md:10](https://github.com/openclaw/openclaw/blob/b6423fbd323cc1ecfc8ef452b7d862a5ec0685f8/docs/install/node.md#L10) + - command: `nl -ba docs/install/node.md | sed -n '1,80p'` + - sha: [b6423fbd323c](https://github.com/openclaw/openclaw/commit/b6423fbd323cc1ecfc8ef452b7d862a5ec0685f8) +- **Local-prefix docs default:** `docs/install/installer.md` describes a pinned local Node runtime and lists `--node-version` defaulting to `22.22.0`, but does not prominently explain the difference from the Node 24 recommendation or native-module rebuild implications. + - file: [docs/install/installer.md:190](https://github.com/openclaw/openclaw/blob/b6423fbd323cc1ecfc8ef452b7d862a5ec0685f8/docs/install/installer.md#L190) + - command: `nl -ba docs/install/installer.md | sed -n '61,275p'` + - sha: [b6423fbd323c](https://github.com/openclaw/openclaw/commit/b6423fbd323cc1ecfc8ef452b7d862a5ec0685f8) +- **Served install-cli behavior:** The public `install-cli.sh` currently defaults `OPENCLAW_NODE_VERSION` to `22.22.0` and skips replacing an existing managed Node when its major version is at least 22. + - command: `curl -fsSL https://openclaw.ai/install-cli.sh | nl -ba | sed -n '1,260p'; curl -fsSL https://openclaw.ai/install-cli.sh | nl -ba | sed -n '300,520p'` +- **Related-item check:** Exact-title and local-prefix Node searches found this issue as the only exact docs/defaults request; related runtime-drift work at https://github.com/openclaw/openclaw/issues/75250 and https://github.com/openclaw/openclaw/pull/76092 covers service/runtime selection rather than this docs clarification. + - command: `curl -fsSL 'https://api.github.com/search/issues?q=repo:openclaw/openclaw%20%22Clarify%20Node%20defaults%22' | jq -r '.items[] | [.number, .state, .title, .html_url] | @tsv'` +- **History routing:** GitHub commit history for the affected install docs and installer script shows recent work by `steipete` and install-doc maintenance by `vincentkoc`. + - command: `curl -fsSL 'https://api.github.com/repos/openclaw/openclaw/commits?path=docs/install/installer.md&per_page=10' | jq -r '.[] | [.sha, .commit.author.date, (.author.login // .commit.author.name), .commit.message] | @tsv'` + +## Likely Related People + +- **steipete:** likely follow-up owner + - reason: Recent commits touched the Node runtime floor/default docs, local installer references, and installer behavior; the affected docs and installer paths repeatedly route through this history. + - confidence: high + - commits: 955b0256976a7f964db8ce968ac325594dbf3c15, 93d8a8602b2d6f91181f5f3ada321517c1c30287, 6f50253a4d08b567da0c244f33a2d526d0bbea0c, 5f13af6b68603c49367e1540212779d1dcafafb2 + - files: docs/install/installer.md, docs/install/index.md, docs/install/node.md, scripts/install.sh +- **vincentkoc:** recent docs maintainer + - reason: Recent install-doc commits updated install page structure, frontmatter, formatting, and related install documentation hygiene around the affected pages. + - confidence: medium + - commits: f0b6c65e3b0982ec7633b10c7eedb9eafd0242fc, bff5051e38e1a2ac1c0ab6aeb88504480d334ea9, e36cb33379c02b91533ef41b1250ba7d5ba73192, 78e4f5188af519c3e61e259540e88eac22e548d0 + - files: docs/install/installer.md, docs/install/index.md, docs/install/node.md +- **sallyom:** adjacent installer maintainer + - reason: Recent current-main history includes installer-script follow-up command work, making this person a secondary routing candidate for installer output copy if the fix expands beyond docs. + - confidence: low + - commits: 56fe64e8e36978fa31a4c8ddaa1246db0377acb2 + - files: scripts/install.sh + +## Risks / Open Questions + +- Changing the local-prefix managed Node default from 22.22.0 to Node 24 would be a product/release decision; the narrow safe path is docs and warning copy. + +## Close Comment + +_No close comment posted._ + +## GitHub Snapshot + +- comments: 0 +- timeline events: 0 +- related items: 0 +- PR files: 0 +- PR commits: 0 + +## Review Telemetry + +- prompt chars: 38510 +- static prompt chars: 33412 +- context chars: 3859 +- schema chars: 14081 +- additional prompt chars: 0 +- context collection ms: 1423 +- Codex review ms: 209078 + \ No newline at end of file