From 1377f69351943666077ebdf46d56e038a952a176 Mon Sep 17 00:00:00 2001 From: freewil Date: Wed, 26 Mar 2014 00:21:01 -0700 Subject: [PATCH] fix ssl self-signed tests for node v0.11 --- test/ssl.js | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/test/ssl.js b/test/ssl.js index cc93461..8474a67 100644 --- a/test/ssl.js +++ b/test/ssl.js @@ -3,34 +3,40 @@ var assert = require('assert'), clone = require('clone'), bitcoin = require('../'), config = require('./config'); - + var getInfo = function(opts, cb) { var client = new bitcoin.Client(opts); client.getInfo(cb); }; - + describe('Client SSL', function() { it('use sslStrict by default', function(done) { var opts = clone(config); opts.ssl = true; getInfo(opts, function(err, info) { assert.ok(err instanceof Error); - assert.equal(err.message, 'DEPTH_ZERO_SELF_SIGNED_CERT'); + // node v0.11 adds `code` param to this error + // and uses a user-friendly `message` + // continue using err.message for v0.8 and v0.10 + assert.equal(err.code || err.message, 'DEPTH_ZERO_SELF_SIGNED_CERT'); done(); }); }); - + it('strictSSL should fail with self-signed certificate', function(done) { var opts = clone(config); opts.ssl = true; opts.sslStrict = true; getInfo(opts, function(err, info) { assert.ok(err instanceof Error); - assert.equal(err.message, 'DEPTH_ZERO_SELF_SIGNED_CERT'); + // node v0.11 adds `code` param to this error + // and uses a user-friendly `message` + // continue using err.message for v0.8 and v0.10 + assert.equal(err.code || err.message, 'DEPTH_ZERO_SELF_SIGNED_CERT'); done(); }); }); - + it('self-signed certificate with sslStrict false', function(done) { var opts = clone(config); opts.ssl = true; @@ -41,7 +47,7 @@ describe('Client SSL', function() { done(); }); }); - + it('self-signed certificate with sslStrict and CA specified', function(done) { var opts = clone(config); opts.ssl = true; @@ -52,5 +58,5 @@ describe('Client SSL', function() { done(); }); }); - + });