coldcard/modcryptocurrency
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bugs/robustness

Browse Source
This commit is contained in:
Peter D. Gray 2018-05-23 12:02:57 -04:00
parent de3cedc27a
commit 2a6f399e90
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
modtcc-codecs.c
View File

@ -115,6 +115,12 @@ STATIC mp_obj_t modtcc_b32_decode(mp_obj_t enc)
}
STATIC MP_DEFINE_CONST_FUN_OBJ_1(modtcc_b32_decode_obj, modtcc_b32_decode);
//
//
// Bech32 aka. Segwit addresses, but hopefylly not specific to segwit addresses only.
//
//
// pack and unpack bits; probably 5 or 8...
//
STATIC inline int
@ -145,9 +151,6 @@ sw_convert_bits(
return 1;
}
//
// Bech32 aka. Segwit addresses, but hopefylly not specific to segwit addresses only
//
STATIC mp_obj_t modtcc_bech32_encode(mp_obj_t hrp_obj, mp_obj_t segwit_version_obj, mp_obj_t data_obj)
{
const char *hrp = mp_obj_str_get_str(hrp_obj);
@ -227,17 +230,23 @@ int bech32_decode(
);
*/
char hrp[strlen(s) - 6];
uint8_t tmp[strlen(s) - 8]; // actually 8-bit
char hrp[strlen(s) + 16];
uint8_t tmp[strlen(s) + 16]; // actually 8-bit
size_t tmp_len = 0;
int rv = bech32_decode(hrp, tmp, &tmp_len, s);
if(rv != 1) {
// transcription error from user is very likely
// probably transcription error from user
mp_raise_ValueError("corrupt bech32");
}
if(tmp_len <= 1) {
// lots of valid Bech32 strings, but invalid for segwit puposes
// can end up here; but don't care.
mp_raise_ValueError("no sw verion and/or data");
}
// re-pack 5-bit data into 8-bit bytes (after version)
uint8_t packed[tmp_len];
size_t packed_len = 0;