From 0904630474824e0f23545daecdae09f1ffebe1bb Mon Sep 17 00:00:00 2001 From: "Peter D. Gray" Date: Sat, 21 Sep 2019 11:23:49 -0400 Subject: [PATCH] Revert "(in)Correctness" This reverts commit bc374640bb87ec047d127f936279a4e9c886618a. --- modtcc-secp256k1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modtcc-secp256k1.c b/modtcc-secp256k1.c index 350acf7..1031489 100644 --- a/modtcc-secp256k1.c +++ b/modtcc-secp256k1.c @@ -18,9 +18,9 @@ STATIC mp_obj_t mod_trezorcrypto_secp256k1_generate_secret() { uint8_t out[32]; for (;;) { random_buffer(out, 32); - // check whether: 0 < secret < curve_order + // check whether secret > 0 && secret < curve_order if (0 == memcmp(out, "\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00", 32)) continue; - if (0 < memcmp(out, "\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFE\xBA\xAE\xDC\xE6\xAF\x48\xA0\x3B\xBF\xD2\x5E\x8C\xD0\x36\x41\x41", 32)) continue; + if (0 <= memcmp(out, "\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFE\xBA\xAE\xDC\xE6\xAF\x48\xA0\x3B\xBF\xD2\x5E\x8C\xD0\x36\x41\x41", 32)) continue; break; } return mp_obj_new_bytes(out, sizeof(out));