diff --git a/releases/ChangeLog.md b/releases/ChangeLog.md index a3a16785..13e1a98f 100644 --- a/releases/ChangeLog.md +++ b/releases/ChangeLog.md @@ -10,6 +10,7 @@ - Enhancement: `12 Words` menu option preferred on the top of the menu in all the seed menus (rather than 24 words). - Bugfix: Handle any failures in slot reading when loading settings +- Bugfix: Add missing First Time UX for extended key import as master seed ## 5.2.0 - 2023-10-10 diff --git a/shared/seed.py b/shared/seed.py index c3cf971f..c569b8f3 100644 --- a/shared/seed.py +++ b/shared/seed.py @@ -543,7 +543,7 @@ async def ephemeral_seed_generate(nwords): async def set_seed_extended_key(extended_key): encoded, chain = xprv_to_encoded_secret(extended_key) set_seed_value(encoded=encoded, chain=chain) - goto_top_menu() + goto_top_menu(first_time=True) async def set_ephemeral_seed_extended_key(extended_key, meta=None): encoded, chain = xprv_to_encoded_secret(extended_key) diff --git a/testing/test_ux.py b/testing/test_ux.py index 90802b5d..a75cc034 100644 --- a/testing/test_ux.py +++ b/testing/test_ux.py @@ -287,7 +287,9 @@ def test_import_from_dice(count, nwords, goto_home, pick_menu_item, cap_story, n @pytest.mark.parametrize('multiple_runs', range(3)) @pytest.mark.parametrize('nwords', [12, 24]) -def test_new_wallet(nwords, goto_home, pick_menu_item, cap_story, need_keypress, cap_menu, get_secrets, unit_test, pass_word_quiz, multiple_runs, reset_seed_words, expect_ftux): +def test_new_wallet(nwords, goto_home, pick_menu_item, cap_story, need_keypress, + cap_menu, get_secrets, unit_test, pass_word_quiz, multiple_runs, + reset_seed_words, expect_ftux): # generate a random wallet, and check seeds are what's shown to user, etc unit_test('devtest/clear_seed.py') @@ -323,7 +325,7 @@ def test_new_wallet(nwords, goto_home, pick_menu_item, cap_story, need_keypress, @pytest.mark.parametrize('testnet', [True, False]) def test_import_prv(way, testnet, pick_menu_item, cap_story, need_keypress, unit_test, cap_menu, word_menu_entry, get_secrets, microsd_path, multiple_runs, reset_seed_words, - nfc_write_text, settings_set, virtdisk_path): + nfc_write_text, settings_set, virtdisk_path, expect_ftux): if testnet: netcode = "XTN" settings_set('chain', 'XTN') @@ -380,7 +382,7 @@ def test_import_prv(way, testnet, pick_menu_item, cap_story, need_keypress, unit need_keypress("y") pick_menu_item(fname) - unit_test('devtest/abort_ux.py') + expect_ftux() v = get_secrets()