coldcard/firmware
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

signatures always max 71 bytes

Browse Source
This commit is contained in:
scgbckbone 2024-07-17 12:29:21 +02:00 committed by doc-hex
parent 2d85b3299c
commit 74bbcfacfd
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
shared/psbt.py
View File

@ -1959,8 +1959,8 @@ class psbtObject(psbtProxy):
# We need to grind sometimes to get a positive R
# value that will encode (after DER) into a shorter string.
# - saves on miner's fee (which might be expected/required)
# - blends in with Bitcoin Core signatures which do this
for retry in range(10):
# - blends in with Bitcoin Core signatures which do this from 0.17.0
for retry in range(100):
result = ngu.secp256k1.sign(pk, digest, retry).to_bytes()
# convert signature to DER format
@ -1970,7 +1970,6 @@ class psbtObject(psbtProxy):
der_sig = ser_sig_der(r, s, inp.sighash)
if len(der_sig) <= 71:
# odds of needing retry: just under 50% I think
break
# private key no longer required