coldcard/firmware
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

little bug

Browse Source
This commit is contained in:
Peter D. Gray 2025-09-17 10:03:50 -04:00
parent 3291faa31e
commit 54dcf2dce8
No known key found for this signature in database
GPG Key ID: A2DCD558C2BE5D7C
2 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
shared/utils.py
View File

@ -645,7 +645,7 @@ def decode_bip21_text(got):
proto, args, addr = None, None, None
# remove URL protocol: if present
if ':' in got:
if ':' in got[0:16]:
proto, got = got.split(':', 1)
# looks like BIP-21 payment URL

18
testing/test_decoders.py
View File

@ -53,12 +53,13 @@ def test_detector_bin(fname, expect, encoding, try_decode):
@pytest.mark.parametrize('url', [
'bitcoin:mtHSVByP9EYZmB26jASDdPVm19gvpecb5R',
'bitcoin:mtHSVByP9EYZmB26jASDdPVm19gvpecb5R?label=Luke-Jr',
'bitcoin:mtHSVByP9EYZmB26jASDdPVm19gvpecb5R?amount=20.3&label=Luke-Jr',
'bitcoin:mtHSVByP9EYZmB26jASDdPVm19gvpecb5R?amount=50&label=Luke-Jr&message=Donation%20for%20project%20xyz',
'bitcoin:mtHSVByP9EYZmB26jASDdPVm19gvpecb5R?req-somethingyoudontunderstand=50&req-somethingelseyoudontget=999',
'bitcoin:mtHSVByP9EYZmB26jASDdPVm19gvpecb5R?somethingyoudontunderstand=50&somethingelseyoudontget=999',
'mtHSVByP9EYZmB26jASDdPVm19gvpecb5R',
'mtHSVByP9EYZmB26jASDdPVm19gvpecb5R?label=Luke-Jr',
'mtHSVByP9EYZmB26jASDdPVm19gvpecb5R?amount=20.3&label=Luke-Jr',
'mtHSVByP9EYZmB26jASDdPVm19gvpecb5R?amount=50&label=Luke-Jr&message=Donation%20for%20project%20xyz',
'mtHSVByP9EYZmB26jASDdPVm19gvpecb5R?req-somethingyoudontunderstand=50&req-somethingelseyoudontget=999',
'mtHSVByP9EYZmB26jASDdPVm19gvpecb5R?somethingyoudontunderstand=50&somethingelseyoudontget=999',
'mtHSVByP9EYZmB26jASDdPVm19gvpecb5R?label=total%20due:%20500',
])
@pytest.mark.parametrize('bip21', range(2))
@pytest.mark.parametrize('addr_fmt', range(2))
@ -66,8 +67,9 @@ def test_detector_url(url, bip21, addr_fmt, try_decode):
a1, a2 = ('mtHSVByP9EYZmB26jASDdPVm19gvpecb5R',
'BCRT1QUPYD58NDSH7LUT0ET0VTRQ432JVU9JTDX8FGYV')
if not bip21:
_, url = url.split(':', 1)
if bip21:
url = 'bitcoin:' + url
if addr_fmt:
url = url.replace(a1, a2)
expect_addr = a2.lower()