bugfix: do not allow lateral scroll in Address Explorer when showing single address from custom path

This commit is contained in:
scgbckbone 2024-08-30 09:56:27 +02:00 committed by doc-hex
parent 5fa2f385ef
commit 383aafe6f7
3 changed files with 9 additions and 3 deletions

View File

@ -14,11 +14,12 @@ This lists the new changes that have not yet been published in a normal release.
- Enhancement: Improve side-channel protection: libsecp256k1 context randomization now happens
before each signing session.
- Change: Do NOT require descriptor checksum when importing multisig wallets
- Bugfix: Do not alow to import multisig wallet duplicate with only keys shuffled.
- Bugfix: Do not allow to import multisig wallet duplicate with only keys shuffled.
- Bugfix: Do not read whole PSBT into memory when writing finalized transaction.
- Bugfix: Properly handle null data in `OP_RETURN`.
- Bugfix: Prevent user from restoring Seed XOR when len parts is smaller than 2.
- Bugfix: Fix display alignment of Seed Vault menu.
- Bugfix: Do not allow lateral scroll in Address Explorer when showing single address from custom path.
- Change: Remove Lamp Test from Debug Options (lights covered by selftest)
# Mk4 Specific Changes

View File

@ -386,7 +386,9 @@ Press (3) if you really understand and accept these risks.
elif choice == '0' and allow_change:
change = 1
elif n is None:
# makes no sense to do any of below, showing just single address
continue
elif ch in (KEY_LEFT+"7"):
# go backwards in explorer
if start - n < 0:

View File

@ -464,6 +464,10 @@ def test_custom_path(path_sidx, which_fmt, addr_vs_path, pick_menu_item, goto_ad
time.sleep(.2)
if is_single:
# check that lateral scrolling on single address does not cause the yikes
need_keypress(KEY_RIGHT if is_q1 else "9")
need_keypress(KEY_LEFT if is_q1 else "7")
time.sleep(.2)
title, body = cap_story()
assert 'Showing single addr' in body
@ -501,7 +505,6 @@ def test_custom_path(path_sidx, which_fmt, addr_vs_path, pick_menu_item, goto_ad
f_path, f_addr = next(addr_gen)
assert f_path == path
assert f_addr == addr
else:
n = 10
if (start_idx + n) > MAX_BIP32_IDX: