btcpayserver/btcpayserver-plugin-builder
btcpayserver/btcpayserver-plugin-builder
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: keep review mutations out of embed mode

Browse Source
This commit is contained in:
thgO.O 2026-05-30 01:53:21 -03:00
parent 9f31d0c9c0
commit def55cfcac
No known key found for this signature in database
GPG Key ID: EDC540B3D14756CB
2 changed files with 11 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
PluginBuilder/Controllers/HomeController.cs
View File

@ -560,7 +560,7 @@ public class HomeController(
[ValidateAntiForgeryToken]
public async Task<IActionResult> UpsertReview(
[ModelBinder(typeof(PluginSlugModelBinder))]
PluginSlug pluginSlug, int rating, string? body, string? pluginVersion, string? embed = null)
PluginSlug pluginSlug, int rating, string? body, string? pluginVersion)
{
if (rating is < 1 or > 5)
return BadRequest("Invalid rating");
@ -575,7 +575,7 @@ public class HomeController(
if (isOwner)
{
TempData[TempDataConstant.WarningMessage] = "You cannot review your own plugin.";
return RedirectToAction(nameof(GetPluginDetails), "Home", new { pluginSlug = pluginSlug.ToString(), embed = string.IsNullOrEmpty(embed) ? null : embed });
return RedirectToAction(nameof(GetPluginDetails), "Home", new { pluginSlug = pluginSlug.ToString() });
}
var reviewerAccountDetails = await conn.GetAccountDetailSettings(userId) ?? new AccountSettings();
@ -603,8 +603,7 @@ public class HomeController(
var url = Url.Action(nameof(GetPluginDetails), "Home", new
{
pluginSlug = pluginSlug.ToString(),
sort = string.IsNullOrEmpty(sort) ? null : sort,
embed = string.IsNullOrEmpty(embed) ? null : embed
sort = string.IsNullOrEmpty(sort) ? null : sort
});
return Redirect((url ?? "/") + "#reviews");
}
@ -665,8 +664,7 @@ public class HomeController(
[ModelBinder(typeof(PluginSlugModelBinder))]
PluginSlug pluginSlug,
long id,
bool isHelpful,
string? embed = null)
bool isHelpful)
{
var userId = userManager.GetUserId(User);
if (string.IsNullOrEmpty(userId))
@ -685,8 +683,7 @@ public class HomeController(
var url = Url.Action(nameof(GetPluginDetails), new
{
pluginSlug = pluginSlug.ToString(),
embed = string.IsNullOrEmpty(embed) ? null : embed
pluginSlug = pluginSlug.ToString()
});
return Redirect((url ?? "/") + "#reviews");
}
@ -696,8 +693,7 @@ public class HomeController(
public async Task<IActionResult> DeleteReview(
[ModelBinder(typeof(PluginSlugModelBinder))]
PluginSlug pluginSlug,
long id,
string? embed = null)
long id)
{
var userId = userManager.GetUserId(User);
if (string.IsNullOrEmpty(userId))
@ -714,8 +710,7 @@ public class HomeController(
var url = Url.Action(nameof(GetPluginDetails), new
{
pluginSlug = pluginSlug.ToString(),
embed = string.IsNullOrEmpty(embed) ? null : embed
pluginSlug = pluginSlug.ToString()
});
return Redirect((url ?? "/") + "#reviews");
}

8
PluginBuilder/Views/Home/GetPluginDetails.cshtml
View File

@ -318,13 +318,13 @@
}
else
{
<form method="post" asp-action="VoteReview" asp-route-pluginSlug="@Model.Plugin.ProjectSlug" asp-route-id="@review.Id" asp-route-embed="@embedRoute" asp-route-isHelpful="true" class="test-upvote-form d-inline">
<form method="post" asp-action="VoteReview" asp-route-pluginSlug="@Model.Plugin.ProjectSlug" asp-route-id="@review.Id" asp-route-isHelpful="true" class="test-upvote-form d-inline">
@Html.AntiForgeryToken()
<button type="submit" class="@voteBtn vote-up @(review.UserVoteHelpful == true ? "text-success" : "text-secondary")" aria-label="Mark this review as helpful">
<vc:icon symbol="thumb-up" /><span class="small ms-1">@review.UpCount</span>
</button>
</form>
<form method="post" asp-action="VoteReview" asp-route-pluginSlug="@Model.Plugin.ProjectSlug" asp-route-id="@review.Id" asp-route-embed="@embedRoute" asp-route-isHelpful="false" class="test-downvote-form d-inline">
<form method="post" asp-action="VoteReview" asp-route-pluginSlug="@Model.Plugin.ProjectSlug" asp-route-id="@review.Id" asp-route-isHelpful="false" class="test-downvote-form d-inline">
@Html.AntiForgeryToken()
<button type="submit" class="@voteBtn vote-down @(review.UserVoteHelpful == false ? "text-danger" : "text-secondary")" aria-label="Mark this review as not helpful">
<vc:icon symbol="thumb-down" /><span class="small ms-1">@review.DownCount</span>
@ -346,7 +346,7 @@
<button type="button" class="btn btn-link btn-sm p-0 text-danger align-self-start ms-2"
title="Delete" aria-label="Delete review"
data-bs-toggle="modal" data-bs-target="#ConfirmModal"
data-action='@Url.EnsureLocal(Url.Action("DeleteReview", "Home", new { pluginSlug = Model.Plugin.ProjectSlug, id = review.Id, embed = embedRoute }), Context.Request)'
data-action='@Url.EnsureLocal(Url.Action("DeleteReview", "Home", new { pluginSlug = Model.Plugin.ProjectSlug, id = review.Id }), Context.Request)'
data-title="Delete review"
data-description="Delete this review? This action cannot be undone."
data-confirm="Delete">
@ -370,7 +370,7 @@
}
else
{
<form id="review-form" method="post" asp-action="UpsertReview" asp-controller="Home" asp-route-pluginSlug="@Model.Plugin.ProjectSlug" asp-route-embed="@embedRoute">
<form id="review-form" method="post" asp-action="UpsertReview" asp-controller="Home" asp-route-pluginSlug="@Model.Plugin.ProjectSlug">
@Html.AntiForgeryToken()
<div id="ratingStars" class="d-inline-flex align-items-center gap-1 fs-4 mb-3" role="radiogroup" aria-label="Rating (1 to 5)" tabindex="0">
@for (var i = 1; i <= 5; i++)