From 027a5245597fe1d6d078ea2c3624eba6223ad894 Mon Sep 17 00:00:00 2001 From: Jeff Vandrew Jr <43861226+JeffVandrewJr@users.noreply.github.com> Date: Wed, 24 Jul 2019 13:54:46 -0400 Subject: [PATCH 1/3] Update README.md --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index e564342..5fed937 100644 --- a/README.md +++ b/README.md @@ -57,6 +57,10 @@ fetched_invoice = client.get_invoice() ``` The `fetched_invoice` above will be a dictionary of all invoice data from the Bitpay API. For instance, you can check the payment status with `fetched_invoice['status']`. +This `get_invoice` method is very important. When BTCPay sends a payment notification (described [here in Bitpay's API docs](https://bitpay.com/docs/create-invoice)), it is unsigned and insecure. Being unsigned and insecure is necessary to maintain compatibility with software originally designed for Bitpay. You therefore cannot rely upon the data transmitted in the payment notification. + +Instead, take the `invoiceId` from the payment notification, and use it to securely fetch the paid invoice data from BTCPay using the `get_invoice` method above. + ### Get a list of invoices matching certain parameters ```python From fc258bffb536f2db7a802decf23a4386b0fca9d8 Mon Sep 17 00:00:00 2001 From: Saurabh130 <54713778+Saurabh130@users.noreply.github.com> Date: Mon, 2 Sep 2019 14:28:19 +0530 Subject: [PATCH 2/3] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5fed937..4cb97dd 100644 --- a/README.md +++ b/README.md @@ -19,7 +19,7 @@ To connect your website with your BTCPay server, you must first pair your applic ``` Label: Public key: leave blank -Facade: 'merchant' +#Facade: 'merchant' (No longer available . The developer had removed it.) ``` 3. Click save and then copy the 7 digit pairing code from the success page From 5141f176537248954d266a66367a9842f478f3af Mon Sep 17 00:00:00 2001 From: Saurabh130 <54713778+Saurabh130@users.noreply.github.com> Date: Mon, 2 Sep 2019 14:33:46 +0530 Subject: [PATCH 3/3] Update README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 4cb97dd..403ceab 100644 --- a/README.md +++ b/README.md @@ -19,7 +19,6 @@ To connect your website with your BTCPay server, you must first pair your applic ``` Label: Public key: leave blank -#Facade: 'merchant' (No longer available . The developer had removed it.) ``` 3. Click save and then copy the 7 digit pairing code from the success page