From 04fed2f06f965759104f90d2d45b882e17c797e0 Mon Sep 17 00:00:00 2001
From: Dominic Go <18517029+dominicstop@users.noreply.github.com>
Date: Fri, 12 Nov 2021 09:11:47 +0800
Subject: [PATCH] =?UTF-8?q?=F0=9F=93=9D=20Updated=20`TODO`?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
---
docs/TODO.md | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/docs/TODO.md b/docs/TODO.md
index 53f4c25..f2d5f82 100644
--- a/docs/TODO.md
+++ b/docs/TODO.md
@@ -5,8 +5,6 @@
- [ ] **Implement**: `ContextMenu` — Add support for `UIDefferedElement`.
- [ ] **Refactor**: Use structs instead of classes for holding configuration for making the menu items.`
-- [ ] **Cleanup**: Breaking Change — Remove legacy support for icon config shorthand/shortcut that was added temporarily when migrating between the older version.
-- [ ] **Cleanup**: Remove `RCTSwiftLog` Usage.
- [ ] **Cleanup**: Remove print logs.
@@ -14,6 +12,7 @@
- [ ] **Refactor**: Update logic for handling `URI` images.
- [ ] **Refactor**: Refactor to use typescript + add type annotations.
- [ ] **Refactor**: Refactor example to use typescript.
+- [ ] **Refactor**: Replace `RCT` prefix with `RNI`.
@@ -28,11 +27,15 @@
-- [x] **Sync**: Import the core libraries in `react-native-ios-context-menu`.
+- [ ] **Sync**: Import the core libraries in `react-native-ios-context-menu`.
+ * Import `RNIImageItem` and update `RCTMenuIcon` to use it.
- [ ] Read apple documentation to find any new changes added.
+- [ ] Example #13 — Setting `discoverabilityTitle` no longer does anything.
+ * In iOS 13, this used to show a subtitle blurb below the menu item title. In iOS 15, it no longer displays the subtitle.
+ * In iOS 15, there's a new property added called `UIMenuElement.subtitle`?.
@@ -50,6 +53,8 @@
- [x] (Commit: `59d4faf`) **Refactor**: Migrate `Extension+Init`-related types to use failable initializers instead of static functions.
- [x] (Commit: `7bb8148`) **Cleanup**: Update `MARK` comments in native code.
- [x] (Commit: `873b61a`) **Cleanup**: Cleanup swift types (e.g. `NSString` -> `String`).
+- [x] (Commit: `ebfa1cc`) **Cleanup**: Remove `RCTSwiftLog` + usage.
+- [x] (Commit: `3041c9c`) **Cleanup**: Breaking Change — Remove legacy support for icon config shorthand/shortcut that was added temporarily when migrating between an older version of this library.
---