* Added pause and resume recording functionality for android version 24 onwards
* Added pause and resume recording functions to Camera1.java
Co-authored-by: Pradeep Asundi <pradeep@asundi.in>
* feat(android): expose an ability to change the frames per second
adding ability to change the video recording
frame per second using [MediaRecorder.setVideoFrameRate][1].
[1]: https://developer.android.com/reference/android/media/MediaRecorder#setVideoFrameRate(int)
* feat(android): adding getSupportedPreviewFpsRange
adding getSupportedPreviewFpsRange method to retrieve
supported android devices frame rates for recording.
* feat(android): updating docs
* feat(android): fix api docs type
* feat(android): adding typescript promise type
* feat(android): log message for Camera2
* feat(android): iOS error if method invoked
Triggering error if android only method getSupportedPreviewFpsRange is invoked on iOS.
* feat(android): expose an ability to change the frames per second
adding ability to change the video recording
frame per second using [MediaRecorder.setVideoFrameRate][1].
[1]: https://developer.android.com/reference/android/media/MediaRecorder#setVideoFrameRate(int)
* feat(android): adding getSupportedPreviewFpsRange
adding getSupportedPreviewFpsRange method to retrieve
supported android devices frame rates for recording.
* feat(android): updating docs
* feat(android): fix api docs type
* feat(android): adding typescript promise type
* feat(android): log message for Camera2
* feat(android): iOS error if method invoked
Triggering error if android only method getSupportedPreviewFpsRange is invoked on iOS.
* add TouchEvent on android
* add GestureHandler to detect touches on android
* add property to enable touchDetector on android
* add onTouch event to ios
* add GestureRecognizer to ios
* add onTouch property and js setup
* add missing semicolons
* fix literal notation
* add missing ":"
* fix copy-paste error (wrong var-name)
* pass the native event to the onTouch callback
* replace : with ;
* add onTouch type defs
* add documentation for onTouch property
* scale postion before emitting since the event coordinates are raw pixels
* migrate advanced example to native pinch zoom and onTouch
* split onTouch property into onTap and onDoubleTap
* add native zoom on android
* add native zoom on ios
* add useNativeZoom property
* extract compution of maxZoomFactor to a method
* use optional maxZoomFactor for native zoom
* add useNativeZoom Property to typescript declaration
* add doc entry for useNativeZoom
* add synchronized to take pictures callback in case camera was already stopped.
This will also prevent a possible null camera object.
* use our mCamera variable instead of the one received in the callback so we know if it has been disposed.
Co-authored-by: Cristiano Coelho <cristianocca@hotmail.com>
Shutter sound should now be consistent with the `playSoundOnCapture` prop. Additionally, it should happen on successful capture as opposed to camera capture start (consistent with iOS and any camera app)
Lastly, added missing props to the docs.
* This update tries to improve audio recording interruptions on iOS due to phone calls or background music.
- Use a more generic event to handle session interruptions. This removes the need to listen to foreground/background events, and stopping the session this way was actually redundant/wrong (see https://forums.developer.apple.com/thread/61406). This also makes session stopping detection more reliable (calls, suspension due to a call or notification, etc., which would previously not set the recording interrupted flag on every case)
From the above docs: "No, incorrect. You _never_ need to stop your capture session. The capture session automatically stops itself when your app goes to the background and resumes itself when you come back to the foreground."
- Allow for `captureAudio` updates to also update the audio connections internally so the prop can be correctly updated on the fly without remounting.
- add onAudioInterrupted and onAudioConnected events so the UI can handle scenarios where audio is wanted but not available. This should also help in keeping the preview active even if audio is interrupted and we have captureAudio={true}. Lastly, it can be used to detect if we can record audio or not due to the dummy implementation of the audio permission on iOS always returning true.
- check, activate, and release audio sessions (if captureAudio) so we can detect early if audio is available before attempting to connect the input. This will also allow us to detect if we can record even if there was already a call before opening the camera.
- use proper observer for session error instead of of the strong self block. No benefit, but makes code more readable and allows access to instance variables
- getDeviceOrientationWithBlock might fire more than once under some circumstances, ending up taking a picture or video twice. Add a lock and additional check to prevent this.
* no need for change check,
* do not resume audio if we were hinted not to (e.g., music playback happening)
* Move heavy work to a dedicated background thread. Improves camera initial loading and resumes from background.
Details:
- Use a HandlerThread to delegate heavy tasks to background. The thread is managed by the view, and passed down to the implementation in case it also needs to use it. The view will fire start calls and other possibly heavy operations in this thread to avoid ANRs. Some code sent to this thread:
- start calls: start is extremely heavy and will cause ANRs on some devices, especially when coming back from background
- Camera1: some preset changes fire a stop/start sequence. These will now happen in the background thread
- take picture and start recording (from view class) will also start in this thread
- Add some extra null checks
- View was not properly cleaning up itself on destroy (host destroy event was never fired)
* Fix for a possible crash when changing devices and changing focus. If the new device resets the focus, "defocusing" might not be possible if the new device does not support auto focus. For this reason, we need to do a different cleanup on the focus and exposed flags and events.
* start session here also on session queue.
* check for session running before trying to record or capture.
This should fix a possible race condition where both the session start call happens at the same time as the record call
* set preview orientation also in session queue
* no need to set orientation on constructor, and set it on session queue to prevent race conditions
* move device init and checks also to session queue. This prevents possible double initializations.
* catch possible errors when starting camera preview. This might still randomly fail on some devices for some reason.
* delay capture in progress until we have resumed/paused preview.
* do not crash the app if set texture setup failed
* more synchronized checks to prevent crashes due to concurrent camera updates
* remove unused imports
* Handle audio interruption in session queue. This prevents the session isRunning flag from getting corrupted due to concurrent updates to the session.
* Fix possible crash when attempting to retrieve camera parameters.
* Preserve exif/metadata on photo capture. Add a few comments to each step of the capture process
* orientation must be fixed before mirroring
* x/y dimensions are redundantly updated (storing the image sets them automatically). However, orientation must be reset on any image change since the final stored image is automatically rotated when it is modified in place.
* revert mirrorImage order, has to be first since forceUpOrientation adjusts the image afterwards.
* Minor change: also implement `onPictureTaken` for iOS in case anyone needs the early event.
* - Improve Android code so skipProcessing is not needed, the code is more in line with iOS, and is "fast" by default. This means that skipProcessing is no longer needed (nor used), and adding additional options will "slow down" the capture as expected, rather than having always a lot of processing. This shouldn't be a breaking change.
- document the writeExif option, and implement it for iOS as well.
* This is a fix for events possibly being fired not on the main thread, which could cause the whole app to freeze.
* Fire events on the right thread. No need to use UI thread, and fix the still works
* Release CF object which could cause a memleak
* Fix Objects.equals that is only available after API 19
* allow for audio session to be kept even after unmounts
* readme typo
* readme typo
* Make camera ready events to fire also on camera/device change to be consistent with Android. Fire unmount error when session or device fails to start.
* update example app to properly use camera ready event
* Make camera ready events to fire also on camera/device change to be consistent with Android. Fire unmount error when session or device fails to start. Update advanced example app to use camera ready event instead.
* Android crash fixes. Make sure no unsupported aspect ratio is used, and do not crash when there are no cameras available.
* stop/release camera in non-UI thread so we prevent ANRs and UI freezing.
Some phones may take up to a second to release the camera and preview.
* move codec, max duration, and max file size settings to the session queue.
This might prevent a race condition when changing presets/quality.
* android crash fix
* Add onRecordingStart and onRecordingEnd events
* fix for surface destroy and resume events.
* add missing types
* fix for surface destroy and resume events.
* add missing types
Co-authored-by: Cristiano Coelho <cristianocca@hotmail.com>
* stop/release camera in non-UI thread so we prevent ANRs and UI freezing.
Some phones may take up to a second to release the camera and preview.
* fix for surface destroy and resume events.
Co-authored-by: Cristiano Coelho <cristianocca@hotmail.com>
* - Improve Android code so skipProcessing is not needed, the code is more in line with iOS, and is "fast" by default. This means that skipProcessing is no longer needed (nor used), and adding additional options will "slow down" the capture as expected, rather than having always a lot of processing. This shouldn't be a breaking change.
- document the writeExif option, and implement it for iOS as well.
* Release CF object which could cause a memleak
* This is a fix for events possibly being fired not on the main thread, which could cause the whole app to freeze.
* Fire events on the right thread. No need to use UI thread, and fix the still works
* Move heavy work to a dedicated background thread. Improves camera initial loading and resumes from background.
Details:
- Use a HandlerThread to delegate heavy tasks to background. The thread is managed by the view, and passed down to the implementation in case it also needs to use it. The view will fire start calls and other possibly heavy operations in this thread to avoid ANRs. Some code sent to this thread:
- start calls: start is extremely heavy and will cause ANRs on some devices, especially when coming back from background
- Camera1: some preset changes fire a stop/start sequence. These will now happen in the background thread
- take picture and start recording (from view class) will also start in this thread
- Add some extra null checks
- View was not properly cleaning up itself on destroy (host destroy event was never fired)
* catch possible errors when starting camera preview. This might still randomly fail on some devices for some reason.
* delay capture in progress until we have resumed/paused preview.
* do not crash the app if set texture setup failed
* more synchronized checks to prevent crashes due to concurrent camera updates
* remove unused imports
* Torch fixes for iOS and a few nil checks.
- Torch turned on by default should work as expected (turned on after mounting and camera type switch)
- Torch maintained when video recording starts (it will flicked if preset has to change)
- Torch resumed when app comes back from background (it is disabled on session pause)
* Fix Torch mode while recording for Android as well.
* Android only: Support to enumerate Camera devices and to select from one of them.
* No need to have the camera in running state if querying for IDs.
* Silly bug, not using string compare. Also, do not run any camera code if the actual camera doesn't change.
* Crash fix when focus coordinates are set to null/undefined not being handled. Notes about not supported flash/focus
* If a camera is not found, set the first available camera just like Camera2 does.
* missing semicolon
* Fixes to Camera2 API:
- First change is related to camera selection by ID. Some more code was required to correctly set the facing flag and characteristics
- Second change fixes a previous issue (unrelated to the PR) that was causing the preview of the camera to look upside down on rotated devices. Device rotation should not affect the display (nor set it). Device rotation should however be used for the final image (and not screen rotation). Some code was borrowed from Camera1.
Setting a property ends up with an unhandled exception that cannot be caught easily by RN. This should also make the behaviour consistent with camera startup and Camera2.
These changes include the following:
- use atomic boolean for capturing photo flag just like video
- add more exception catching and checks
- raise error instead of failing silently if can't capture photo - improve error handling here
- synchronize stop to avoid race conditions and crashes
- delay params updates (surface) if capturing or recording to avoid bugs
- do not allow video or photo capture if already doing video or photo
* Use standardized exposure value between 0 and 1
* Add iOS native exposure control
* Delete logging
* Add documentation + spell fixes
* Update RNCamera.m
* Remove reset of exposure after tap-to-focus
First, it updates the take picture call to capture right away instead of trying to focus again. This will match closer to what the native camera does, and also what the Camera2 does.
Secondly, it removes all calls to resetFocus after capturing and after a given timeout. This was causing issues when using autoFocusPointOfInterest, and it really didn't make sense to use an internal timeout to reset the focus. If anything, the user should do this from the JS side. A new method could also be exposed to do this.
Lastly, it adds some error catching logic to the autoFocus call. There was a chance on some devices that calling autoFocus while the device is capturing a photo that it would fail.
Tested on Google Pixel 2 (Android 9), Motorola G5 (Android 8), Samsung Grand Prime (Android 5?), and LG20 (android 6?). No issues so far.
