bluewallet/react-native-camera
bluewallet/react-native-camera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(android): Add an additional error check to avoid crashes on Android. This fix comes from testing on multiple devices, where for some unknown reason the decode process fails and returns null and the app crashes immediately due to a null pointer exception. This attempts to handle this issue more gracefully. (#2446)

Browse Source
This commit is contained in:
cristianoccazinsp 2019-09-02 15:29:17 -03:00 committed by Sibelius Seraphini
parent ea935bd4c2
commit 497e4a21d8
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
android/src/main/java/org/reactnative/camera/tasks/ResolveTakenPictureAsyncTask.java
View File

@ -69,6 +69,9 @@ public class ResolveTakenPictureAsyncTask extends AsyncTask<Void, Void, Writable
if (mBitmap == null) {
mBitmap = BitmapFactory.decodeByteArray(mImageData, 0, mImageData.length);
}
if(mBitmap == null){
throw new IOException("Failed to decode Image bitmap.");
}
response.putInt("width", mBitmap.getWidth());
response.putInt("height", mBitmap.getHeight());
@ -78,9 +81,11 @@ public class ResolveTakenPictureAsyncTask extends AsyncTask<Void, Void, Writable
response.putString("uri", fileUri);
} catch (Resources.NotFoundException e) {
response = null; // do not resolve
mPromise.reject(ERROR_TAG, "Documents directory of the app could not be found.", e);
e.printStackTrace();
} catch (IOException e) {
response = null; // do not resolve
mPromise.reject(ERROR_TAG, "An unknown I/O exception has occurred.", e);
e.printStackTrace();
}